[Bug 1014738] Review Request: python-astropy - A Community Python Library for Astronomy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1014738



--- Comment #16 from Michael Schwendt <bugs.michael@xxxxxxx> ---
* Please don't dump _unedited_ fedora-review output into review tickets. You
are supposed to complete all empty '[ ]' tests in the output, and trimming the
output to items that are '[!]' would be very helpful.


* How are the two -devel package supposed to work? They contain exactly the
same headers, but only in different paths. The headers are stored below Python
search path for modules. What mechanism will be used in the C code to determine
that path? And since there are only headers, how does it work? Is there any
example that uses these headers already? Or will it be sufficient to include
the headers in the base package?


> %exclude %{_bindir}/fitsdiff
> %exclude %{_bindir}/fitscheck

Why are they excluded?


> -rwxr-xr-x  /usr/bin/volint
> -rwxr-xr-x  /usr/bin/wcslint

These are included in both the Python package and the Python 3 based package.
But in python-astropy, the files contain a /usr/bin/python3 shebang. ->
blocker!
And with a corrected shebang, the packages would conflict. -> blocker!

$ rpm -qpR python-astropy-0.3-0.1.b1.fc21.x86_64.rpm |grep bin
/usr/bin/python3
/usr/bin/xmllint

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]