https://bugzilla.redhat.com/show_bug.cgi?id=1022317 --- Comment #2 from Scott Talbert <swt@xxxxxxxxxx> --- (In reply to František Dvořák from comment #1) > - No known owner of /usr/x86_64-w64-mingw32/sys- > root/mingw/include/hidapi, /usr/i686-w64-mingw32/sys- > root/mingw/include/hidapi > Native package hidapi.spec owns the whole include/hidapi directory so there > it is OK. Fixed. > - the command: > find %{buildroot} -name '*.la' -exec rm -f {} ';' > > would be better written: > find %{buildroot} -name "*.la" -delete Fixed. > - MinGW guidelines requires versioned dependencies of mingw32/64-filesystem: > BuildRequires: mingw32-filesystem >= 95 > BuildRequires: mingw64-filesystem >= 95 > > I'm not sure if there is still technical reason for it (Fedoras 18+ have > proper versions already), but it is mentioned at > https://fedoraproject.org/wiki/Packaging:MinGW?rd=Packaging/ > MinGW#Dependencies Fixed. > - an unimportant detail (it is up to you if to change anything): native > version hidapi.spec has "make %{?_smp_mflags} V=1" and mingw-hidapi.spec has > "%mingw_make %{?_smp_mflags}", the "V=1" could be probably in both packages, > or removed from the native I think I will probably just remove it from the native package. > - just a tip: the %{summary} macro could be used in mingw32-hidapi and > mingw64-hidapi subpackages What does the summary macro do? (I could not find any documentation on it.) Enable you to just repeat the summary line from above to avoid having duplicate information? Thanks for the feedback. New SPEC: http://www.techie.net/~talbert/hidapi/mingw-hidapi.spec NEW SRPM: http://www.techie.net/~talbert/hidapi/mingw-hidapi-0.7.0-2.a88c724.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review