[Bug 1022317] Review Request: mingw-hidapi - Library for communicating with USB and Bluetooth HID devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1022317



--- Comment #1 from František Dvořák <valtri@xxxxxxxxxx> ---
Found issues (although probably only the first one is an issue :-)):


- No known owner of /usr/x86_64-w64-mingw32/sys-
     root/mingw/include/hidapi, /usr/i686-w64-mingw32/sys-
     root/mingw/include/hidapi
 Native package hidapi.spec owns the whole include/hidapi directory so there it
is OK.


- the command:
 find %{buildroot} -name '*.la' -exec rm -f {} ';'

  would be better written:
 find %{buildroot} -name "*.la" -delete

  as in example at
https://fedoraproject.org/wiki/Packaging:MinGW?rd=Packaging/MinGW#Example_Specfile


- MinGW guidelines requires versioned dependencies of mingw32/64-filesystem:
 BuildRequires:  mingw32-filesystem >= 95
 BuildRequires:  mingw64-filesystem >= 95

  I'm not sure if there is still technical reason for it (Fedoras 18+ have
proper versions already), but it is mentioned at
https://fedoraproject.org/wiki/Packaging:MinGW?rd=Packaging/MinGW#Dependencies


- an unimportant detail (it is up to you if to change anything): native version
hidapi.spec has "make %{?_smp_mflags} V=1" and mingw-hidapi.spec has
"%mingw_make %{?_smp_mflags}", the "V=1" could be probably in both packages, or
removed from the native


- just a tip: the %{summary} macro could be used in mingw32-hidapi and
mingw64-hidapi subpackages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]