[Bug 1025196] Review Request: fcitx-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1025196



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package builds in mock f21

+ rpmlint on generated rpms gave
fcitx-skk.src: W: spelling-error %description -l en_US libskk -> basilisk
fcitx-skk.src: W: strange-permission fcitx-skk-0.1.0.tar.xz 0600L
fcitx-skk.x86_64: W: spelling-error %description -l en_US libskk -> basilisk
fcitx-skk.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 4 warnings.


+ Source verified with upstream as (sha256sum)
srpm tarball : 41c433592e965c95d4b383b036a828c0646ae875540eb10b56ac63cd30a89630
upstream tarball :
41c433592e965c95d4b383b036a828c0646ae875540eb10b56ac63cd30a89630

+ License is valid and included as headers in source files.


Suggestions:
1) Group tag is no longer mandatory, you can remove it.

2) include COPYING as %doc


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]