https://bugzilla.redhat.com/show_bug.cgi?id=1026139 --- Comment #1 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- Looks good overall, just a couple directory issues, at least one of which isn't your issue at all... -- MUST: [!]: Package requires other packages for directories it uses. [!]: Package must own all directories that it creates. There are three directories that aren't owned by this package or any of its dependencies: > %{_datadir}/vala/vapi This probably should be in a "vala-appstream" subpackage that Requires vala: http://www.redhat.com/archives/fedora-packaging/2009-February/msg00022.html > /usr/lib64/packagekit-plugins This is actually a bug in PackageKit. It ships several files in that directory itself, but nobody owns it. > /usr/share/gir-1.0 % repoquery --whatprovides /usr/share/gir-1.0 | wc -l 46 All -devel packages. I'm pretty sure all these packages should all just be requiring gobject-instrospection-devel? SHOULD: [x]: Rpmlint is run on all rpms the build produces. Checking: appstream-0.4.0-1.fc19.x86_64.rpm appstream-devel-0.4.0-1.fc19.x86_64.rpm appstream-0.4.0-1.fc19.src.rpm > appstream.x86_64: W: name-repeated-in-summary C AppStream This make sense in this case. > appstream-devel.x86_64: W: no-documentation rpmlint really should whitelist -devel subpackages... > appstream.src:32: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 32) In the commented-out Requires line. > appstream.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libappstream.so.0.4.0 /lib64/libm.so.6 CMake overlinking as per usual. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review