[Bug 1024136] Review Request: gedit-template - Gedit plugin to create new files from templates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1024136



--- Comment #30 from Germán Racca <gracca@xxxxxxxxx> ---
(In reply to Michael Schwendt from comment #29)
> > My logic is: Gedit requires Python 3 (because 'rpm -q --requires gedit'
> > says 'python(abi) = 3.3'), and this plugin requires Gedit.
> 
> This is okay, because _currently_ it works. Currently, package gedit
> contains an explicit dependency on Python 3. But generally, you cannot
> guarantee that such a dependency won't move to a different package (and
> actually, moved dependencies have lead to run-time breakage before).
> gedit-template directly needs Python 3, so that should be added as a package
> dependency.

Thanks for sharing your experience on packaging!


> > Byte compiled files are present in my system:
> 
> That looks as if they have been bytecompiled for Python 2. The Python 3
> based __pycache__ dir is missing.

You are right. I looked at the content of the package gedit-plugins, and it has
the __pycache__ directory. 


> > Why is that?
> 
> Try adding to the spec:
> 
> %global __python %{__python3}

That did the trick. It created the __pycache__ dir with the corresponding files
inside it:

$ rpmls RPMS/x86_64/gedit-template-0.0.2-2.fc19.x86_64.rpm 
drwxr-xr-x  /usr/lib64/gedit/plugins/__pycache__
-rw-r--r--  /usr/lib64/gedit/plugins/__pycache__/template.cpython-33.pyc
-rw-r--r--  /usr/lib64/gedit/plugins/__pycache__/template.cpython-33.pyo
-rw-r--r--  /usr/lib64/gedit/plugins/template.plugin
-rw-r--r--  /usr/lib64/gedit/plugins/template.py
drwxr-xr-x  /usr/share/doc/gedit-template-0.0.2
-rw-r--r--  /usr/share/doc/gedit-template-0.0.2/LICENSE
-rw-r--r--  /usr/share/doc/gedit-template-0.0.2/README


Please find updated files here:

Spec URL: http://skytux.fedorapeople.org/packages/gedit-template.spec

SRPM URL:
http://skytux.fedorapeople.org/packages/gedit-template-0.0.2-2.fc19.src.rpm

Koji build from scratch for F19:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6130529

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]