https://bugzilla.redhat.com/show_bug.cgi?id=1025977 --- Comment #3 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Michele Baldessari from comment #2) > Hi Antonio, > > thanks for letting me know. I've uploaded fixed spec and srpm: > Spec URL: http://acksyn.org/files/rpms/captcp/captcp.spec > SRPM URL: http://acksyn.org/files/rpms/captcp/captcp-1.6-2.fc20.src.rpm > > I increased the release tag, hope that is okay. Here is the changelog: > * Sat Nov 02 2013 Michele Baldessari <michele@xxxxxxxxxx> - 1.6-2 > - Fixed two hardcoded dirs in install section (Antonio Trande > <anto.trande@xxxxxxxxx>) You don't need to indicate my Name/Surname/Mail. Please, don't do that. Hardcoded directory names must be avoided in the whole file. > - Added texlive-epstopdf-bin in Requires as socketstatistic requires it > - Added a patch to correct some help messages > > I've now git-ified the patch applying (a bit like in xorg-x11-server) so > rpmlint now needlessly warns about: > captcp.spec: W: patch-not-applied Patch0: > 0001-The-option-is-called-statistic-not-statistics.patch Probably, it means that you have not applied the patch included in your source rpm. You can simply use the %patch command in the %setup section. See http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25prep_section:_.25patch_commands and http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment Remove the line 'rm -rf $RPM_BUILD_ROOT' in the %install section. Why have you erased the '%{buildroot}/{_bindir}/captcp' file ? Leave a comment to explain your reasons. ;) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review