https://bugzilla.redhat.com/show_bug.cgi?id=1024134 --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Parag AN(पराग) from comment #1) > Suggestions: > > 1) good if unnecessary information is removed from font wiki page > > 2) generally we create wiki pages with all the words in small letter 1-2: I didn't write the wiki page :) I already removed some stuff from there, what exactly do you have in mind? > 3) why this package name starts with gust? You want to use it as foundry? If > yes good to add some reference like how gust is related to this font. When I > search on google, I found its related in this link > http://www.gust.org.pl/projects/e-foundry Yes, they (GUST="tex users group") have a bunch of fonts, so I intend to add at least "gust-antykwa-pultawskiego-fonts" later on. > 4) Upstream URL should be http://jmn.pl/en/antykwa-torunska/ Fixed. > 5) good if all %global are written at top of spec I moved one. %versiontag I kept, it is better to keep it next to %{version}, which it uses. > 6) I don't think you need to %global shortname to be added as its only used > once and not changing value so better remove it. This specfile should be reusable without almost any changes for some of the other fonts from gust, so this %global is in preparation for that. > 7) %description text looks very big. Can it be reduced? Definitely. Fixed. > 8)You need to specify some priority to this config file. You can see the > reference for this in /etc/fonts/conf.d/README. you can choose any number > from 60 to 69 I used 69. Thank you for the comments. Spec URL: http://in.waw.pl/~zbyszek/fedora/gust-antykwa-torunska.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/gust-antykwa-torunska-fonts-2.08-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review