https://bugzilla.redhat.com/show_bug.cgi?id=1024134 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@xxxxxxxxx --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Suggestions: 1) good if unnecessary information is removed from font wiki page 2) generally we create wiki pages with all the words in small letter 3) why this package name starts with gust? You want to use it as foundry? If yes good to add some reference like how gust is related to this font. When I search on google, I found its related in this link http://www.gust.org.pl/projects/e-foundry 4) Upstream URL should be http://jmn.pl/en/antykwa-torunska/ 5) good if all %global are written at top of spec 6) I don't think you need to %global shortname to be added as its only used once and not changing value so better remove it. 7) %description text looks very big. Can it be reduced? 8)You need to specify some priority to this config file. You can see the reference for this in /etc/fonts/conf.d/README. you can choose any number from 60 to 69 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review