[Bug 1022584] Review Request: qpid-qmf - The QPID Management Framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1022584



--- Comment #6 from Darryl L. Pierce <dpierce@xxxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #5)
> 1. > 10. Dist tag is missing.                                               
> 
> Still missing.                                                              

Hrm, though I'd added it. Fixed (definitely) now.

> 2. Requires:  qpid-cpp-client%{?_isa} = %{version}-%{release}               
> 
> Is this necessary?

Yes.

> The dependency should be picked up automatically. Also,
> it ties this package to  qpid-cpp-client, when you said
> that they should become independent.         

No, I said that at the source code level the Qpid team is separating the QMF
codebase from the Qpid codebase; i.e., when a Qpid sources are released it's
not going to contain QMF code. We want the packages separate, even though QMF
will still have a dependency on what Qpid provides.

> Rpmlint                                                                     
> 
> -------                                                                     
> 
> Checking: qpid-qmf-0.24-11.fc21.x86_64.rpm                                  
> 
>           qpid-qmf-devel-0.24-11.fc21.x86_64.rpm                            
> 
>           qpid-qmf-0.24-11.src.rpm                                          
> 
> qpid-qmf.x86_64: W: spelling-error %description -l en_US scalability
> qpid-qmf.x86_64: W: no-manual-page-for-binary qmf-toolqpid-qmf-devel.x86_64:
> W: no-documentation 
> qpid-qmf-devel.x86_64: W: no-manual-page-for-binary qmf-gen
> qpid-qmf.src: W: spelling-error %description -l en_US scalability
> 3 packages and 0 specfiles checked; 0 errors, 5 warnings.                   
> 
>                                                                             
> 
> Mostly irrelevant, apart from the missing manpages.
> I suggest using help2man to generate the missing manpages.

I'll update the Cmake in the upstream code and add manpages there.

Updated spec:  http://mcpierce.fedorapeople.org/rpms/qpid-qmf.spec
Updated SRPM: 
http://mcpierce.fedorapeople.org/rpms/qpid-qmf-0.24-12.fc19.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6107331

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]