https://bugzilla.redhat.com/show_bug.cgi?id=1022584 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- 1. > 10. Dist tag is missing. Still missing. 2. Requires: qpid-cpp-client%{?_isa} = %{version}-%{release} Is this necessary? The dependency should be picked up automatically. Also, it ties this package to qpid-cpp-client, when you said that they should become independent. Rpmlint ------- Checking: qpid-qmf-0.24-11.fc21.x86_64.rpm qpid-qmf-devel-0.24-11.fc21.x86_64.rpm qpid-qmf-0.24-11.src.rpm qpid-qmf.x86_64: W: spelling-error %description -l en_US scalability qpid-qmf.x86_64: W: no-manual-page-for-binary qmf-toolqpid-qmf-devel.x86_64: W: no-documentation qpid-qmf-devel.x86_64: W: no-manual-page-for-binary qmf-gen qpid-qmf.src: W: spelling-error %description -l en_US scalability 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Mostly irrelevant, apart from the missing manpages. I suggest using help2man to generate the missing manpages. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 16 files have unknown license. Detailed output of licensecheck in /var/tmp/review-qpid-qmf/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. Yes, but see note above. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 10 files. [x]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python See below. [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. Builds in koji. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf.so.1.0.0 /lib64/libqmfengine.so.1 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf.so.1.0.0 /lib64/libuuid.so.1 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf.so.1.0.0 /lib64/libboost_system.so.1.54.0 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf.so.1.0.0 /lib64/libboost_program_options.so.1.54.0 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf.so.1.0.0 /lib64/libdl.so.2 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf.so.1.0.0 /lib64/librt.so.1 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf.so.1.0.0 /lib64/libm.so.6 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf2.so.1.0.0 /lib64/libqpidclient.so.2 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf2.so.1.0.0 /lib64/libuuid.so.1 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf2.so.1.0.0 /lib64/libboost_system.so.1.54.0 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf2.so.1.0.0 /lib64/libboost_program_options.so.1.54.0 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf2.so.1.0.0 /lib64/libdl.so.2 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf2.so.1.0.0 /lib64/librt.so.1 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmf2.so.1.0.0 /lib64/libm.so.6 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfengine.so.1.1.0 /lib64/libqpidtypes.so.1 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfengine.so.1.1.0 /lib64/libuuid.so.1 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfengine.so.1.1.0 /lib64/libboost_system.so.1.54.0 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfengine.so.1.1.0 /lib64/libboost_program_options.so.1.54.0 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfengine.so.1.1.0 /lib64/libdl.so.2 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfengine.so.1.1.0 /lib64/librt.so.1 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfengine.so.1.1.0 /lib64/libm.so.6 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfconsole.so.2.0.0 /lib64/libqpidtypes.so.1 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfconsole.so.2.0.0 /lib64/libuuid.so.1 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfconsole.so.2.0.0 /lib64/libboost_system.so.1.54.0 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfconsole.so.2.0.0 /lib64/libboost_program_options.so.1.54.0 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfconsole.so.2.0.0 /lib64/libdl.so.2 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfconsole.so.2.0.0 /lib64/librt.so.1 qpid-qmf.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqmfconsole.so.2.0.0 /lib64/libm.so.6 [!]: Package functions as described. See below. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. There's something wrong with installation directories for python files: % /usr/bin/qmf-gen Traceback (most recent call last): File "/usr/bin/qmf-gen", line 23, in <module> from qmfgen.schema import SchemaPackage, SchemaClass ImportError: No module named qmfgen.schema I see: /usr/lib/python2.7/site-packages/qmfgen /usr/lib/python2.7/site-packages/qmfgen/qmfgen /usr/lib/python2.7/site-packages/qmfgen/qmfgen/__init__.py ... and also /usr/lib64/python2.7/site-packages/_cqmf2.so /usr/lib64/python2.7/site-packages/_cqpid.so /usr/lib64/python2.7/site-packages/_qmfengine.so /usr/lib64/python2.7/site-packages/cqmf2.py /usr/lib64/python2.7/site-packages/cqmf2.pyc /usr/lib64/python2.7/site-packages/cqmf2.pyo /usr/lib64/python2.7/site-packages/cqpid.py /usr/lib64/python2.7/site-packages/cqpid.pyc /usr/lib64/python2.7/site-packages/cqpid.pyo /usr/lib64/python2.7/site-packages/qmf /usr/lib64/python2.7/site-packages/qmf.py /usr/lib64/python2.7/site-packages/qmf.pyc /usr/lib64/python2.7/site-packages/qmf.pyo /usr/lib64/python2.7/site-packages/qmf/__init__.py /usr/lib64/python2.7/site-packages/qmf/__init__.pyc /usr/lib64/python2.7/site-packages/qmf/__init__.pyo /usr/lib64/python2.7/site-packages/qmf/console.py /usr/lib64/python2.7/site-packages/qmf/console.pyc /usr/lib64/python2.7/site-packages/qmf/console.pyo /usr/lib64/python2.7/site-packages/qmf2.py /usr/lib64/python2.7/site-packages/qmf2.pyc /usr/lib64/python2.7/site-packages/qmf2.pyo /usr/lib64/python2.7/site-packages/qmfengine.py /usr/lib64/python2.7/site-packages/qmfengine.pyc /usr/lib64/python2.7/site-packages/qmfengine.pyo So there's one level extra, and one level missing. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review