https://bugzilla.redhat.com/show_bug.cgi?id=1022283 --- Comment #11 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Mosaab Alzoubi from comment #9) > RE-review :: > > 1. Done > 2. Done The URL should be the content of Source0, not in the comments. Use: Source0: http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=snapshot;h=%{githead};sf=tgz;name=gnulib-25fb29a.tar.gz Source1: http://erislabs.net/gitweb/?p=gnulib.git;a=blob_plain;hb=HEAD;f=debian/manpages/check-module.1 Source2: http://erislabs.net/gitweb/?p=gnulib.git;a=blob_plain;hb=HEAD;f=debian/manpages/gnulib-tool.1 > 3. Done > 4. Done > 5. Done > 6. Done > 7. Done > 8. Done > 9. Done > 10. ??? Explain , make (all) isn't do any thing ! You call 'make info' and 'make html'. It should be: 'make %{?_smp_mflags} info html' > 11. Done > 12. Done 13. So, once docs have been built, there's no need to install the sources. gnulib-doc should contain: gnulib.info gnulib.html (and the main package should *not* have them). 14. README is useless, do not package it. 15. Also, all those chmod's are *not* necessary: some of those are executable files, and the permissions in the git archive on them are OK. 16. .gitattributes should also be removed. > Ok guys : > > I need this package to build this one :) > https://bitbucket.org/sortsmill/sortsmill-tools Like Ralf pointed out implicitly, you don't really *need* to: https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Packages_granted_exceptions https://fedorahosted.org/fpc/ticket/174 I find https://git.kernel.org/cgit/linux/kernel/git/kay/libabc.git great for testing gnulib... With your current package, gnulib-tool --import seems to work, gnulib-tool --test too, so I think we're on the proper path here. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review