https://bugzilla.redhat.com/show_bug.cgi?id=1022644 --- Comment #6 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- (In reply to Remi Collet from comment #5) > Small notice, I don't think it make sense to have a %{github_version}. For GitHub packages, I like to see all the GitHub information at the top vs. some at the top and some lower down in the spec. Since the version is actually the GitHub tag I like to include that at the top. (In reply to Remi Collet from comment #4) > [!]: Requires correct, justified where necessary. > php-common => php(language) I hang my head in shame :( > [!]: If the source package does not include license text(s) as a separate > file > from upstream, the packager SHOULD query upstream to include it. > > "Common licenses that require including their texts with all > derivative works include ASL 2.0, EPL, BSD and MIT." > => have to wait for upstream to add this file > https://github.com/sdboyer/gliph/issues/1 > => So this will be a blocker. > > > As LICENSE is now part of upstream repo, you can add it > Source1: https://raw.github.com/sdboyer/gliph/php53/LICENSE I hang my head in shame again :( I noticed this but didn't account for it in the spec :( I updated to the latest snapshot since it now contains the LICENSE file. Update diff: https://github.com/siwinski/rpms/commit/2a69ec1373c680577274fdc5fb24faa28ab87fd4 Spec URL: https://github.com/siwinski/rpms/blob/2a69ec1373c680577274fdc5fb24faa28ab87fd4/php-gliph.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-gliph-0.1.4-1.20131024git8da23c6.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review