https://bugzilla.redhat.com/show_bug.cgi?id=973069 --- Comment #20 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Alec Leamas from comment #19) > > On line 33, please use %{_datadir} instead of /usr/share. > > On line 47 and 48 please use %{_sharedstatedir} instead of /var/lib. > I'd prefer not to: http://fedoraproject.org/wiki/Packaging:Guidelines#macros Ok, no problem. > > > Group: Development/Tools > Isn't Group: tag allowed?: > http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag Ok, as you prefer. Are you planning to build this also in EPEL? > > > Package does not contain duplicates in %files. > > > Note: warning: File listed twice: /var/lib/lpf/packages/spotify-client/state > > > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles > > > > You can remove line 48; line 47 already includes everything beneath the > > directory listed. To make it list only one directory (so you can keep line > > 48) please use the %dir macro which only adds the directory and not the > > contents. > Yes, but I need to set the permissions correct. If I remove that line I need > to add a %defattr(664)+ %attr(644) to all files. Certainly possible, but > better? "scratches my head" Ok. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review