https://bugzilla.redhat.com/show_bug.cgi?id=973069 --- Comment #19 from Alec Leamas <leamas.alec@xxxxxxxxx> --- (In reply to Simone Caronni from comment #18) > Issues: [cut] > The license is MIT, but there's no license file installed. Please provide > one in %doc. Done. > > [!]: Package consistently uses macros (instead of hard-coded directory names). > > On line 33, please use %{_datadir} instead of /usr/share. > On line 47 and 48 please use %{_sharedstatedir} instead of /var/lib. I'd prefer not to: http://fedoraproject.org/wiki/Packaging:Guidelines#macros > > > [!]: SourceX tarball generation or download is documented. > > [!]: SourceX is a working URL. > > [!]: Spec file according to URL is the same as in SRPM. > > Note: 0 or more than one spec file in srpm(!) > > See: (this test has no URL) > > There is no documentation nor procedure on how to regenerate the source > tarball. I guess this is about spotify-client.spec? If so, there is no need for this since the Source: url is OK: http://fedoraproject.org/wiki/Packaging:SourceURL#Github > Please provide an external script in the source (like Mesa) or provide > comments in the SPEC file. Also the versioning needs documenting, where does > 0.9.4.183.g644e24e.428 come from? I assume it's a snapshot, so if you paste > commands to regenerate the tarball that would be ok. The version field is the upstream spotify version, I don't really see what kind of comment that would be? Added the fact that this is indeed upstream version. [cut] > > Group: Development/Tools Isn't Group: tag allowed?: http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag > > %description > > Please make the first description line a bit longer so that it goes nearer > to the 80 columns limit. Done. > > > Package does not contain duplicates in %files. > > Note: warning: File listed twice: /var/lib/lpf/packages/spotify-client/state > > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles > > You can remove line 48; line 47 already includes everything beneath the > directory listed. To make it list only one directory (so you can keep line > 48) please use the %dir macro which only adds the directory and not the > contents. Yes, but I need to set the permissions correct. If I remove that line I need to add a %defattr(664)+ %attr(644) to all files. Certainly possible, but better? "scratches my head" BTW, on f20 rpmlint crashes on this ;) > Rpmlint issues: > > lpf-spotify-client.noarch: W: invalid-url > > URL: http://leamas.fedorapeople.org/spotify/0.9.0/lpf-spotify-client.spec > > HTTP Error 404: Not Found> > Please fix, see above comment for source. All the other warnings do not > apply here so packages are ok. Fixed for now, need to create a better upstream on github before importing, though. In future, it would be good you mentioned which spec you are referring to.. New problem ,for sure. Updated in-place, same links, changelog updated. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review