https://bugzilla.redhat.com/show_bug.cgi?id=1003057 --- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Tim Lauridsen from comment #3) > Issues: > Perl: > [!]: Package contains the mandatory BuildRequires and Requires:. > Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; > echo > $version)) missing? No, that is required for perl modules. This package does not contain any modules, just scripts. > The tools package contains perls scripts, so it must require perl The autogenerated Requires include /usr/bin/perl (see the Requires section at the bottom of comment 2), which is sufficient. > Generic: > [!]: Package should not use obsolete m4 macros > Note: Some obsoleted macros found, see the attachment. > See: https://fedorahosted.org/FedoraReview/wiki/AutoTools Fixed. (In reply to Tim Lauridsen from comment #4) > $ cat *.pl | grep -i "^use " | sort | uniq > use File::Basename; > use Getopt::Long "GetOptions"; > use strict; > > I am no perl expert but i think you need > > Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo > $version)) > Requires: perl(File::Basename) > Requires: perlGetopt::Long) > Requires: perl(strict) > > They are all provided by perl, but that can change in the future The autogenerated dependencies already include the last 3, and the first one isn't needed since there is no perl module. New URLs: Spec URL: http://jjames.fedorapeople.org/irstlm/irstlm.spec SRPM URL: http://jjames.fedorapeople.org/irstlm/irstlm-5.80.03-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review