https://bugzilla.redhat.com/show_bug.cgi?id=1021721 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Group: → not necessary cd $RPM_BUILD_DIR/%{_realname}-%{version} → not necessary Since you are also upstream for salttesting (judging by the email address): don't use bare 'except:' ever: it catches ^C. Not necessary, but it would be nice to fix. And also, can you include a license file upstream? setup.py says Python 3 is alpha state... Are there any plans for full support? (See https://fedoraproject.org/wiki/Changes/Python_3_as_Default). Looks nice and clear. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review