[Bug 979767] Review Request: kapow - A punch clock program

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=979767



--- Comment #14 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
(In reply to Michael Schwendt from comment #13)
> What Christopher fails to mention is that the "hicolor-icon-theme" is a
> "-filesystem" type of package. It only contains the basic structure for the
> hicolor icon theme tree, i.e. no icons but just directories, documentation,
> and a few support files.
> 
> That's covered in the yellow box here:
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your
> _package_to_function

I did read that part. I didn't realize hicolor-icon-theme was a filesystem type
package. 

> 
> As such, it is preferred if you "Requires: hicolor-icon-theme" to get right
> the ownership for those many dirs. The alternative would not be pretty:

I've added this to the spec. 

> 
> > %{_datadir}/icons/hicolor/*/apps/%{name}.*
> 
> Isn't sufficient. At least these would not be included:
> 
>   %{_datadir}/icons/hicolor
>   %{_datadir}/icons/hicolor/*
>   %{_datadir}/icons/hicolor/*/apps

Thanks for the clarification Michael. 

Warm regards,
Ankur

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]