[Bug 1015752] Review Request: qt5-qtx11extras - Qt5 - X11 support library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1015752

Tim Lauridsen <tla@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from Tim Lauridsen <tla@xxxxxxxxx> ---
Looks good

only minor issue

[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define pre alpha

You can change it to %global or give a justification 

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]