https://bugzilla.redhat.com/show_bug.cgi?id=853553 --- Comment #60 from MartinKG <mgansser@xxxxxxxx> --- (In reply to Kevin Kofler from comment #59) > Upstream's CMakeLists.txt does this: > FIND_PACKAGE(Subversion) > IF(Subversion_FOUND) > Subversion_WC_INFO(${PROJECT_SOURCE_DIR} GUAYADEQUE) > MESSAGE("Current revision is ${GUAYADEQUE_WC_REVISION}") > SET( _GUREVISION_ ${GUAYADEQUE_WC_REVISION}) > ELSE(Subversion_FOUND) > SET( _GUREVISION_ "" ) > ENDIF(Subversion_FOUND) > > In particular, this line: > Subversion_WC_INFO(${PROJECT_SOURCE_DIR} GUAYADEQUE) > runs "svn info" on the current directory to obtain the revision and store it > in the CMake variable GUAYADEQUE_WC_REVISION, which is then copies to the > CMake variable _GUREVISION_, presumably to show it in some about dialog or > something. And the tarball they ship is a working copy in an outdated format > (outdated SVN version). (IMHO, shipping SVN working copies rather than > exports as tarballs is broken in the first place.) > > IMHO, just removing the .svn directories (i.e. converting the working copies > to a clean export) is the best fix, but you could also run "svn upgrade" in > the specfile (with BuildRequires: subversion) if you think it's important to > have the revision show up (but you could also manually specify > -D_GUREVISION_:STRING=1885 on the cmake command line to get that). @kevin i have set a find .. command in prep section and the -D_GUREVISION_ option in the command line, is this ok ? %prep %setup -q -n %{name}-svn%{svnrev} %patch0 -p1 # deleting Unity parts in guayadeque.desktop files sed -i '18,38d' guayadeque.desktop # remove bundled libraries rm -rf src/wx/wxsql* src/wxsqlite3 # remove .svn dirs find -type d -name .svn | xargs rm -rf .svn %build mkdir -p build-guayadeque && pushd build-guayadeque %cmake \ -DCMAKE_VERBOSE_MAKEFILE=TRUE \ -DCMAKE_INSTALL_PREFIX="%{_prefix}" \ -DCMAKE_SKIP_RPATH=FALSE \ -DCMAKE_BUILD_WITH_INSTALL_RPATH=FALSE \ -D_GUREVISION_:STRING=%{svnrev} \ .. make %{?_smp_mflags} popd -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review