[Bug 853553] Review Request: guayadeque - Audio player and organizer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=853553



--- Comment #59 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> ---
Upstream's CMakeLists.txt does this:
        FIND_PACKAGE(Subversion)
        IF(Subversion_FOUND)
          Subversion_WC_INFO(${PROJECT_SOURCE_DIR} GUAYADEQUE)
          MESSAGE("Current revision is ${GUAYADEQUE_WC_REVISION}")
          SET( _GUREVISION_ ${GUAYADEQUE_WC_REVISION})
        ELSE(Subversion_FOUND)
          SET( _GUREVISION_ "" )
        ENDIF(Subversion_FOUND)

In particular, this line:
          Subversion_WC_INFO(${PROJECT_SOURCE_DIR} GUAYADEQUE)
runs "svn info" on the current directory to obtain the revision and store it in
the CMake variable GUAYADEQUE_WC_REVISION, which is then copies to the CMake
variable _GUREVISION_, presumably to show it in some about dialog or something.
And the tarball they ship is a working copy in an outdated format (outdated SVN
version). (IMHO, shipping SVN working copies rather than exports as tarballs is
broken in the first place.)

IMHO, just removing the .svn directories (i.e. converting the working copies to
a clean export) is the best fix, but you could also run "svn upgrade" in the
specfile (with BuildRequires: subversion) if you think it's important to have
the revision show up (but you could also manually specify
-D_GUREVISION_:STRING=1885 on the cmake command line to get that).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]