https://bugzilla.redhat.com/show_bug.cgi?id=1020088 --- Comment #2 from Thibault North <thibault.north@xxxxxxxxx> --- Thanks for the comments! (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > There's a typo in sed: > sed -i 's|BLOSC_VERSION_PATCH 6|BLOSC_VERSION_PATCH 6|' CMakeLists.txt > ^ should be 3 Thanks, fixed. > I think the description is still awkward... Maybe something like this: > > Blosc is a compression library designed to transmit data to the processor > cache > faster than the traditional non-compressed memory fetch. Compression ratios > are not very high, but the decompression is very fast. Blosc is meant not > only to reduce the size of large datasets on-disk or in-memory, but also to > accelerate > memory-bound computations. Yes, this is better. > > There's a problem with the -devel package's docs (under F20 at least): the > files are installed into /usr/share/doc/bench, and should be in > /usr/share/doc/blosc/bench... I'm not sure what's the best way. One approach: > > --->8---------------------------------------------------------------- > --- /home/zbyszek/rpmbuild/SPECS/blosc.spec~ 2013-10-16 > 21:52:48.000000000 -0400 > +++ /home/zbyszek/rpmbuild/SPECS/blosc.spec 2013-10-17 > 16:45:58.895419994 -0400 > @@ -55,10 +55,6 @@ > > make install DESTDIR=${RPM_BUILD_ROOT} > > -mkdir -p ${RPM_BUILD_ROOT}/%{_docdir}/bench > -cp -pr bench/plot-speeds.py* ${RPM_BUILD_ROOT}/%{_docdir}/bench > -cp -pr bench/*.c ${RPM_BUILD_ROOT}/%{_docdir}/bench > - > %clean > rm -rf ${RPM_BUILD_ROOT} > > @@ -70,11 +66,13 @@ > %doc README.rst ANNOUNCE.rst RELEASE_NOTES.rst README_HEADER.rst > README_THREADED.rst RELEASING.rst > %{_libdir}/libblosc.so.* > > +%global _docdir_fmt %{name} > + > %files devel > %{_libdir}/libblosc.so > %{_includedir}/blosc.h > -%{_docdir}/bench/plot-speeds.py* > -%{_docdir}/bench/*.c > +%doc bench/plot-speeds.py > +%doc bench/*.c > > > %changelog > --->8---------------------------------------------------------------- > > If has the disadvantage that "/bench/" part of the path is gone, all files > are in /usr/share/doc/blosc, and also that the -devel package also has the > docs from the main package (the packages install fine because the files are > indentical). Maybe you can come up with something better. > See https://fedoraproject.org/wiki/Changes/UnversionedDocdirs for more info. About that, why are the files duplicated in this case? I don't remember having met this issue in the past. I also tried this: [...] mkdir -p ${RPM_BUILD_ROOT}/%{_docdir}/%{name}/bench cp -pr bench/plot-speeds.py* ${RPM_BUILD_ROOT}/%{_docdir}/%{name}/bench cp -pr bench/*.c ${RPM_BUILD_ROOT}/%{_docdir}/%{name}/bench [...] %global _docdir_fmt %{name} %files %doc README.rst ANNOUNCE.rst RELEASE_NOTES.rst README_HEADER.rst README_THREADED.rst RELEASING.rst %{_libdir}/libblosc.so.* %files devel %{_libdir}/libblosc.so %{_includedir}/blosc.h %{_docdir}/%{name}/bench/plot-speeds.py* %{_docdir}/%{name}/bench/*.c It is a bit ugly, but keeps the bench/ directory. But again, the main package inherits from the bench/ folder. > > The -devel package requires: > > blosc = 1.2.3-2.fc20 > libblosc.so.1.2.3()(64bit) > Those are duplicates, so > Requires: %{name} = %{version}-%{release} > can be removed. Shouldn't there be an explicit require, according to https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Requiring_Base_Package ? Otherwise, rpmlint complains. > %clean section can be removed. Yes, thanks. rpmlint output: rpmlint -v SRPMS/blosc-1.2.3-3.fc19.src.rpm RPMS/x86_64/blosc-1.2.3-3.fc19.x86_64.rpm RPMS/x86_64/blosc-devel-1.2.3-3.fc19.x86_64.rpm RPMS/x86_64/blosc-debuginfo-1.2.3-3.fc19.x86_64.rpm SPECS/blosc.spec blosc.src: I: checking blosc.src: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases blosc.src: I: checking-url http://blosc.org (timeout 10 seconds) blosc.src: I: checking-url http://blosc.org/sources/1.2.3/blosc-1.2.3.tar.gz (timeout 10 seconds) blosc.x86_64: I: checking blosc.x86_64: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases blosc.x86_64: I: checking-url http://blosc.org (timeout 10 seconds) blosc-devel.x86_64: I: checking blosc-devel.x86_64: I: checking-url http://blosc.org (timeout 10 seconds) blosc-debuginfo.x86_64: I: checking blosc-debuginfo.x86_64: I: checking-url http://blosc.org (timeout 10 seconds) /home/tnorth/rpmbuild/SPECS/blosc.spec: I: checking-url http://blosc.org/sources/1.2.3/blosc-1.2.3.tar.gz (timeout 10 seconds) 4 packages and 1 specfiles checked; 0 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review