[Bug 1020088] Review Request: blosc - A high performance compressor optimized for binary data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1020088



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
There's a typo in sed:
sed -i 's|BLOSC_VERSION_PATCH 6|BLOSC_VERSION_PATCH 6|' CMakeLists.txt
                                                    ^ should be 3


I think the description is still awkward... Maybe something like this:

Blosc is a compression library designed to transmit data to the processor cache 
faster than the traditional non-compressed memory fetch. Compression ratios are
not very high, but the decompression is very fast. Blosc is meant not only to
reduce the size of large datasets on-disk or in-memory, but also to accelerate 
memory-bound computations.


There's a problem with the -devel package's docs (under F20 at least): the
files are installed into /usr/share/doc/bench, and should be in
/usr/share/doc/blosc/bench... I'm not sure what's the best way. One approach:

--->8----------------------------------------------------------------
--- /home/zbyszek/rpmbuild/SPECS/blosc.spec~    2013-10-16 21:52:48.000000000
-0400
+++ /home/zbyszek/rpmbuild/SPECS/blosc.spec     2013-10-17 16:45:58.895419994
-0400
@@ -55,10 +55,6 @@

 make install DESTDIR=${RPM_BUILD_ROOT}

-mkdir -p ${RPM_BUILD_ROOT}/%{_docdir}/bench
-cp -pr bench/plot-speeds.py* ${RPM_BUILD_ROOT}/%{_docdir}/bench
-cp -pr bench/*.c ${RPM_BUILD_ROOT}/%{_docdir}/bench
-
 %clean
 rm -rf ${RPM_BUILD_ROOT}

@@ -70,11 +66,13 @@
 %doc README.rst ANNOUNCE.rst RELEASE_NOTES.rst README_HEADER.rst
README_THREADED.rst RELEASING.rst
 %{_libdir}/libblosc.so.*

+%global _docdir_fmt %{name}
+
 %files devel
 %{_libdir}/libblosc.so
 %{_includedir}/blosc.h
-%{_docdir}/bench/plot-speeds.py*
-%{_docdir}/bench/*.c
+%doc bench/plot-speeds.py
+%doc bench/*.c


 %changelog
--->8----------------------------------------------------------------

If has the disadvantage that "/bench/" part of the path is gone, all files are
in /usr/share/doc/blosc, and also that the -devel package also has the docs
from the main package (the packages install fine because the files are
indentical). Maybe you can come up with something better.
See https://fedoraproject.org/wiki/Changes/UnversionedDocdirs for more info.


The -devel package requires:

blosc = 1.2.3-2.fc20
libblosc.so.1.2.3()(64bit)

Those are duplicates, so 
Requires: %{name} = %{version}-%{release}
can be removed.


%clean section can be removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]