[Bug 1018384] Review Request: tinyca2 - TinyCA graphical openssl based CA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1018384



--- Comment #5 from Patrick Uiterwijk <puiterwijk@xxxxxxxxxx> ---
You have not removed all el5 compat items:
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
and 
%install
rm -rf %{buildroot}


About 6: I know that upstream is dead, but could you add a comment to the spec
where the respective patches are for? (or one comment "These are for perl
compatibility")?


About 3: Sure. I thought you needed to have it in a seperate file, but going
through the guidelines proved me wrong :)


10) Well, this could cause some serious breakage if some application says
"Requires: Perl(GUI)", and the user gets tinyca2 instead of the package
providing perl(GUI), so I think you would need to change that.
This is a known problem, and even has its own section in the Perl packaging
guidelines on how to do this:
https://fedoraproject.org/wiki/Packaging:Perl#Filtering_Requires_and_Provides

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]