https://bugzilla.redhat.com/show_bug.cgi?id=1014619 --- Comment #8 from Dan Mashal <dan.mashal@xxxxxxxxx> --- (In reply to Rex Dieter from comment #4) > and unversioned BR on enlightenment-related deps: > > configure: error: Package requirements (ecore >= 1.7.8 ecore-file >= 1.7.8 > ecore-ipc >= 1.7.8 eet >= 1.7.8 efreet >= 1.7.8 edbus >= 1.7.8 eina >= 1.7.8 > dbus-1 ) were not met: > Requested 'edbus >= 1.7.8' but version of edbus is 1.7.7 > > (also missing optional BR: doxygen, for docs) > > > I'll try to do a more thorough review later today... Indeed doxygen was left out. Added. OK e_dbus was blocked by releng on F20 and I forgot about it. Unblocked and submitted to bodhi now with a BR override. (In reply to Rex Dieter from comment #7) > Initial comments: > > 1. MUST add versioned build deps per comment 4. Can we stick with rawhide for now until e_dbus gets pushed to F20/stable? > 2. -data: runtime dep in this noarch pkg cannot use %_isa, MUST replace > Requires: %{name}%{?_isa} = %{version}-%{release} > with > Requires: %{name} = %{version}-%{release} OK done. > 3. SHOULD play nice with upstream and submit patch to fix typo in > %_libdir/pkgconfig/enlightenment.pc: > Description: Enlightenmnt Window Manager > :) Will do. > 4. -devel pkg afaict, has no strict need for > Requires: %{name}%{?_isa} = %{version}-%{release} > SHOULD consider removing it, but I'll leave that to your discretion Done. > 5. SHOULD consider adding: > Provides: firstboot(windowmanager) = enlightenment > (will help when/if anyone wants to make an enlightenment-based spin) Done. > 6. MUST make dep on -data versioned, replace > Requires: %{name}-data > with > Requires: %{name}-data = %{version}-%{release} Done. > 7. SHOULD consider dropping > %dir %{_sysconfdir}/xdg/menus > and add > Requires: redhat-menus Done. > 8. SHOULD consider moving translations to -data subpkg, ie. > %files data -f %{name}.lang Done. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review