https://bugzilla.redhat.com/show_bug.cgi?id=1014619 --- Comment #7 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Initial comments: 1. MUST add versioned build deps per comment 4. 2. -data: runtime dep in this noarch pkg cannot use %_isa, MUST replace Requires: %{name}%{?_isa} = %{version}-%{release} with Requires: %{name} = %{version}-%{release} 3. SHOULD play nice with upstream and submit patch to fix typo in %_libdir/pkgconfig/enlightenment.pc: Description: Enlightenmnt Window Manager :) 4. -devel pkg afaict, has no strict need for Requires: %{name}%{?_isa} = %{version}-%{release} SHOULD consider removing it, but I'll leave that to your discretion 5. SHOULD consider adding: Provides: firstboot(windowmanager) = enlightenment (will help when/if anyone wants to make an enlightenment-based spin) 6. MUST make dep on -data versioned, replace Requires: %{name}-data with Requires: %{name}-data = %{version}-%{release} 7. SHOULD consider dropping %dir %{_sysconfdir}/xdg/menus and add Requires: redhat-menus 8. SHOULD consider moving translations to -data subpkg, ie. %files data -f %{name}.lang -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review