https://bugzilla.redhat.com/show_bug.cgi?id=904639 --- Comment #6 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Thank you for comments! http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf-0.1.2-1.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf.spec * Thu Oct 3 2013 Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> - 0.1.2-1 - 0.1.2 (In reply to Josef Stribny from comment #5) > 1, There is a newer upstream version (0.1.2). - Updated. > 2, The %description section of -doc sub-package should end up with a dot(.). - Fixed > 3, You should use a macro %{gem_libdir} for lib dir instead of > %{gem_instdir}/lib/ - Well, I prefer to use %{gem_instdir}/lib/ because using %{gem_libdir} makes it difficult to show that %{gem_libdir} is the subdirectory of %{gem_instdir} (i.e. the parent directory of %{gem_libdir} is properly owned), however modified. > 4, And again license file is not separately listed. This requires more work > in the end (for me to check it, for you to check it with every update of the > gem) and it's prone to error. - I always check this... (i.e. I always unpack both the previous version and the new version of tarball / gem / etc, take diff to check what actually changed, judge if it can safely be upgraded.) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z1az8Zqo7T&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review