[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=904639



--- Comment #5 from Josef Stribny <jstribny@xxxxxxxxxx> ---
1, There is a newer upstream version (0.1.2).

2, The %description section of -doc sub-package should end up with a dot(.).

3, You should use a macro %{gem_libdir} for lib dir instead of
%{gem_instdir}/lib/

4, And again license file is not separately listed. This requires more work in
the end (for me to check it, for you to check it with every update of the gem)
and it's prone to error.

Otherwise rpmlint doesn't complain, package builds, installs and runs. Please
fix the issues above so I can approve.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W1A6qFfnRd&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]