https://bugzilla.redhat.com/show_bug.cgi?id=1012077 --- Comment #2 from Darryl L. Pierce <dpierce@xxxxxxxxxx> --- (In reply to Sandro Mani from comment #1) > Polishing: > - %defattr(-,root,root,-) is unnecessary Removed it. > - make install DESTDIR=%{buildroot} can be replaced by %make_install Replaced it. > - escape the % in the comments (i.e. % -> %%) That's a place holder for an update that'll include Python example apps. > - typo in changelog: <dpierce@xxxxxxxxxx -> <dpierce@xxxxxxxxxx> (note the > final >) Fixed. > - is _pkgdocdir needed? Yeah, there's going to be documentation (including the above mentioned examples) in an upcoming update. > - document patches (issue, upstream status) Added the JIRA number for each patch (all are QPID-4952). > Issues: > - empty debuginfo package > Rpmlint: > python-qpid_messaging.x86_64: W: unstripped-binary-or-object > /usr/lib64/python2.7/site-packages/_qpid_messaging.so > python-qpid_messaging.src:59: W: macro-in-comment %{buildroot} > python-qpid_messaging.src:59: W: macro-in-comment %{_datadir} > python-qpid_messaging.src:70: W: macro-in-comment %doc > python-qpid_messaging.src:70: W: macro-in-comment %{_datadir} > python-qpid_messaging.src: W: file-size-mismatch > python-qpid_messaging-0.24.tar.gz = 9410, > http://www.apache.org/dist/qpid/0.24/python-qpid_messaging-0.24.tar.gz = 9518 > 2 packages and 0 specfiles checked; 0 errors, 6 warnings. > > > Rest looks good. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/python-qpid_messaging.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/python-qpid_messaging-0.24-2.fc19.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5984389 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UBVqspoGrK&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review