https://bugzilla.redhat.com/show_bug.cgi?id=1012077 --- Comment #1 from Sandro Mani <manisandro@xxxxxxxxx> --- Polishing: - %defattr(-,root,root,-) is unnecessary - make install DESTDIR=%{buildroot} can be replaced by %make_install - escape the % in the comments (i.e. % -> %%) - typo in changelog: <dpierce@xxxxxxxxxx -> <dpierce@xxxxxxxxxx> (note the final >) - is _pkgdocdir needed? - document patches (issue, upstream status) Issues: - empty debuginfo package Rpmlint: python-qpid_messaging.x86_64: W: unstripped-binary-or-object /usr/lib64/python2.7/site-packages/_qpid_messaging.so python-qpid_messaging.src:59: W: macro-in-comment %{buildroot} python-qpid_messaging.src:59: W: macro-in-comment %{_datadir} python-qpid_messaging.src:70: W: macro-in-comment %doc python-qpid_messaging.src:70: W: macro-in-comment %{_datadir} python-qpid_messaging.src: W: file-size-mismatch python-qpid_messaging-0.24.tar.gz = 9410, http://www.apache.org/dist/qpid/0.24/python-qpid_messaging-0.24.tar.gz = 9518 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Rest looks good. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LdV7sjR2Hi&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review