https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #17 from Volker Fröhlich <volker27@xxxxxx> --- (In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #8) > (In reply to Volker Fröhlich from comment #6) > > I'm not sure if everything that is below /etc really belongs there. I also > > found an icon there, by the way. > Logo, not icon. What you think appropriate path for it? /usr/share/pgmodeler > I suppose? Most other files is *.conf and *.dtd which may be treated as conf > correctly. You can install the icons in %{_datadir}/pixmaps. Please also update the desktop file according to preferred form described in http://fedoraproject.org/wiki/Packaging:Guidelines#Icon_tag_in_Desktop_Files >From the desktop file: "Program with nice Qt interface for visual modeling PostgreSQL database in terms on entity relationship model" -- I'm not a native speaker, but that "on" doesn't sound right. > I think you are by mistake speak about > %{_sysconfdir}/profile.d/%{name}.bash? It is just used to set environment > variables appropriately as theys used by application for function properly. Yes, I was wrong there. Do we really need this profile? It's not like these settings vary on a system-wide scope, as you defined them through packaging. Are there no hard-coded defaults? > > > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libutils.so.1.0.0 /lib64/libpq.so.5 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libutils.so.1.0.0 /lib64/libQtGui.so.4 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libutils.so.1.0.0 /lib64/libxml2.so.2 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libutils.so.1.0.0 /lib64/libXext.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libutils.so.1.0.0 /lib64/libX11.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libutils.so.1.0.0 /lib64/libm.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libpq.so.5 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libxml2.so.2 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libXext.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libX11.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libm.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libdbconnect.so.1.0.0 /lib64/libQtGui.so.4 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libdbconnect.so.1.0.0 /lib64/libxml2.so.2 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libdbconnect.so.1.0.0 /lib64/libXext.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libdbconnect.so.1.0.0 /lib64/libX11.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libdbconnect.so.1.0.0 /lib64/libm.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libpq.so.5 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libxml2.so.2 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libXext.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libX11.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libpq.so.5 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libxml2.so.2 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libXext.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libX11.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libparsers.so.1.0.0 /lib64/libpq.so.5 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libparsers.so.1.0.0 /lib64/libQtGui.so.4 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libparsers.so.1.0.0 /lib64/libpthread.so.0 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libparsers.so.1.0.0 /lib64/libXext.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libparsers.so.1.0.0 /lib64/libX11.so.6 > > pgmodeler.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libparsers.so.1.0.0 /lib64/libm.so.6 > > > > There's some unnecessary linking going on. If these libraries are meant to > > be used by other applications than that GUI, that should probably be > > resolved. > I don't known other usages. That said, I wonder if all the libraries should go to /usr/lib64/pgmodeler instead. Some names are a bit generic and we could drop the devel sub-package and the associated files too. > > The locale script doesn't work because the locales are expected to have some > > kind of prefix to fr_FR. If you prefix them with something like pgmodeler_ > > and run %find_lang %{name} --with-qt, it works. > Will them then work or patching needed? I'd try to rename them before compiling and patch pgmodeler-intl.pro, but I haven't tried that before. > > In my experience, you don't need to BR gettext. > Guidelines said it needed. Only if gettext is used, which is not the case. pgmodeler.src:54: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 54) Some source files miss a license header. Please ask upstream to add them. For the protocol: The error described in comment #14 is sorted out. I suggest to use %{_datadir} instead of %{_datarootdir}. Did you query upstream on the poorly made install target? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J2Owcj5zNP&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review