https://bugzilla.redhat.com/show_bug.cgi?id=1007622 Rino Rondan <villadalmine@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | --- Comment #4 from Rino Rondan <villadalmine@xxxxxxxxx> --- Hi: my changes.. 1- ok , done. 2- The source directory ./images have different png so i want only one to use in order to use it with edfbrowser.desktop that is on sources to apply with desktop configuration, so i choose to use the same that the package name. actual --> install -pm 0644 images/%{name}.png %{buildroot}%{_datadir}/icons/hicolor/48x48/apps/ proposed --> install -pm 0644 images/edf.png %{buildroot}%{_datadir}/icons/hicolor/48x48/apps/%{name}.png Let me know if it is ok . 3- I use /* in order to prevent the creation of extra doc directory after the name of package and plus i added LICENSE file. Regards -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4zzvxlisWE&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review