https://bugzilla.redhat.com/show_bug.cgi?id=1007622 --- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> --- Okay okay ;) 1. I saw your %description is appended without a blank line after the last BR, it's better to leave a blank line for readability. 2. Ah... In %prep: cp -p images/edf.png images/edfbrowser.png then in %install install -pm 0644 images/%{name}.png %{buildroot}%{_datadir}/icons/hicolor/48x48/apps/ I don't understand, why can't you just install -pm 0644 images/edf.png %{buildroot}%{_datadir}/icons/hicolor/48x48/apps/%{name}.png? 3. I can see %doc doc I prefer %doc doc/* as users will enter /usr/share/doc/$(NAME) and then see all docs immediately but not /usr/share/doc/$(NAME)/doc. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mO1r7bU6TQ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review