https://bugzilla.redhat.com/show_bug.cgi?id=1006116 --- Comment #2 from Michael Hampton <error@xxxxxxxxxx> --- Hi Christopher, Thanks for your comments. I have addressed them as follows: 1. This was leftover from upstream. I fixed the URL. 2. This was leftover from upstream. I removed these from the spec file. 3. I added this in to the spec file. 4. The upstream tarball really does have this directory structure. You can download it for yourself and look :) The packaging guidelines said I'm not supposed to alter the tarball (except for patents or binaries in the tarball or other really bad stuff). So that's why this is here in %setup. 5. Upstream doesn't have any build function in their setup.py script. But I added this in anyway, just in case they start doing something later. 6. I have made this change in the spec file. 7. I have made this change in the spec file. 8. I have made these changes in the spec file. 9. I have made these changes in the spec file and manually verified all the permissions in the resulting build. The resulting files can be found at: Spec URL: http://linux.ringingliberty.com/tmp/WALinuxAgent.spec SRPM URL: http://linux.ringingliberty.com/tmp/WALinuxAgent-1.4.0-4.fc19.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5916543 Thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RrSo4mubMf&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review