https://bugzilla.redhat.com/show_bug.cgi?id=1006116 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. URL is invalid. I don't know why you point the URL to a redirect page of https://github.com/windows-azure/walinuxagent ---> https://github.com/WindowsAzure/WALinuxAgent Please change to this. Add Microshit link doesn't mean this is valid. 2. Requires: python-pyasn1 openssh openssl util-linux sed grep sudo iptables You don't need to add "util-linux sed grep sudo" 3. BuildRequires: systemd python-setuptools missing python2-devel 4. %setup -q -n %{name}-%{name}-%{version} # github does this to tarballs github never does this unless some people like this kind of naming way. If you can change it, I recommend "%{name}-%{version}" so you can use %setup -q without %{name}-%{version} or even this weird one "%{name}-%{name}-%{version}" 5. Nothing to build? No python setup.py build? 6. python setup.py install --prefix=%{_prefix} --lnx-distro='redhat' --init-system='systemd' --root=%{buildroot} should be {__python2} setup.py install --prefix=%{_prefix} --lnx-distro='redhat' --init-system='systemd' --root=%{buildroot} 7. %{buildroot}/%{_localstatedir}/log you don't need to add slash between %{buildroot} and %{_localstatedir} just %{buildroot}%{_localstatedir}/log as rpm -E %{_localstatedir} eq /var so if you add a slash the URI will be: //var/log 8. %post preun postun section are all not perfect for f18+ Please check http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd 9. You should avoid using sth. like: %defattr(0644,root,root,0755) and %attr(0755,root,root) Make sure that these file perms are correct during installation, and correct the wrong ones after installation. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nMP0MgnQ8e&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review