[Bug 978284] Review Request: rubygem-redis - A Ruby client library for Redis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=978284

Vít Ondruch <vondruch@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #6 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
Hi, sorry for the delay :/

* ncat
  - You might want to reference bug 978964 in your .spec file, since it seems
    there is also some progress with regard to fallback to IPv4 if IPv6 is not
    available. Let's see, which of the two fixes will land sooner ;)

* rpmlint
  - rpmlint still complains:

    rubygem-redis-doc.noarch: E: version-control-internal-file
        /usr/share/gems/gems/redis-3.0.4/test/db/.gitignore

  - You should exclude the file in -doc subpackage, not in the main package.

* Unstable test suite
  - It seems that test suite may fail sometimes: 

    http://koji.fedoraproject.org/koji/taskinfo?taskID=5882957

  - It might be even ARM related. Who knows ... Second build on ARM was just OK
    and it builds on my laptop just fine. So it might be just worth of
    consultation with upstream. It seems to be just floating point precision
    issue anyway.

Otherwise the package looks good => APPROVED. Please fix the rpmlint issue
prior importing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RaO2tIHHOy&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]