[Bug 978284] Review Request: rubygem-redis - A Ruby client library for Redis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=978284

--- Comment #5 from Axilleas Pipinellis <axilleas@xxxxxxxxxxxx> ---
(In reply to Vít Ondruch from comment #2)
> (In reply to Axilleas Pipinellis from comment #0)
> > (Although, it fails as it cannot open a netcat connection needed by one of
> > tests, will refer about this on devel)
> 
> This can be workarounded by applying:
> 
> sed -i "s/localhost/localhost4/" test/publish_subscribe_test.rb
> 
> prior the test suite is executed. After discussion with ncat maintainer, we
> discovered, that the "localhost" resolves to IPv6 address, while Redis does
> not suppoer IPv6 yet [1]. You might want to try to propose this fix to
> upstream as well, until Redis is IPv6 ready.

Replacing localhost with localhost4 fails with:

[422/485] TestPublishSubscribe#test_subscribe_past_a_timeoutNcat: Could not
resolve hostname "localhost4": Name or service not known. QUITTING.

Which is ok, since in my /etc/hosts I have localhost6 for IPv6 and localhost
for IPv4. I don't think changing these values should be the way of this fix.
How come it plays nice for you? I changed it to 127.0.0.1 in order to pass the
test. 

On another note, some distros still use the old gnu-netcat which doesn't fail
as with ncat. That might be an issue if I opened a bug report.

Finally, I found out that by explicitly telling ncat to use IPv4, build passes.
See this koji build where I passed the -4 switch to nc:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5551282


> * rpmlint error
>   - You should not include dot files in RPM, as is reported by rpmlint:
> 
>     rubygem-redis-doc.noarch: E: version-control-internal-file
>       /usr/share/gems/gems/redis-3.0.4/test/db/.gitignore

Oops, I forgot to run rpmlint on the -doc subpackage... Fixed.

> * Remove Requires: Redis
>   - This is Redis client library. The server can run on Remote machine.
>     Therefore Redis should not be runtime dependency of this package, until
>     there will be some kind of soft dependencies supported by YUM/RPM

Removed.

--------------------

New Spec URL:
http://axilleas.fedorapeople.org/pkgs/rubygem-redis/rubygem-redis.spec
New SRPM URL:
http://axilleas.fedorapeople.org/pkgs/rubygem-redis/rubygem-redis-3.0.4-2.fc19.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5551169

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DFKJcbzVAT&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]