https://bugzilla.redhat.com/show_bug.cgi?id=658754 Michael Schwendt <bugs.michael@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | --- Comment #63 from Michael Schwendt <bugs.michael@xxxxxxx> --- A few more comments: * The Explicit Requires from comment 33 should be reviewed and dropped in favour of the automatic dependencies on library names. At least for ncurses, gc, lzo, and pcre I see corresponding -devel BuildRequires and assume they result in automatic libname deps: https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires Where there are no automatic deps, add comments as explained in the guidelines, and also re-review the BuildRequires. For example, "PCRE library is disabled" appears in the build output. * Several libs are bundled. Configure output says the "builtin" lib will be used -> https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries * Have you tried running the "fedora-review" tool for this package yet? > BuildRequires: systemd-units Prefer "BuildRequires: systemd" which is the package that contains the RPM macros. > build.log It's huge. In many places Fedora's compiler flags aren't used. https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags In some places the build output is not verbose. Hence one cannot verify whether the compiler flags. I haven't checked how to make it more verbose. Sometimes one can configure with --disable-silent-rules, in other cases running "V=1 make …" works. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=27pUwqC4bz&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review