[Bug 1003094] Review Request: python-xml2rfc - Python module for converting IETF RFC-2629 XML into txt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1003094

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m



--- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
The tarball contains a bundled egg-info which has to be removed for building
the package:
rm -rf %{namewithoutpythonprefix}.egg-info

See http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for more
information.

PKG-INFO shouldn't be added to %doc. It is present from the egg-info anyway.
Its content is similar to README and doesn't provide any additional info.

%install
rm -rf $RPM_BUILD_ROOT
The initial cleaning of buildroot is no longer needed because it is default
anyway. It is only needed (probably...?) for EPEL5 packages.


%{python_sitelib}/%{namewithoutpythonprefix}/templates/*
%{python_sitelib}/%{namewithoutpythonprefix}/*.py*
%{python_sitelib}/%{namewithoutpythonprefix}/writers/*.py*

The folders %{python_sitelib}/%{namewithoutpythonprefix}/templates/ and
%{python_sitelib}/%{namewithoutpythonprefix}/writers/ stay unowned. Actually it
should be sufficient to just write
%{python_sitelib}/%{namewithoutpythonprefix}/*
to own the whole folder, its subfolders and the content.

Summary:        Python module for...
The package name already says that it is a Python module, you might write
instead:
Summary:        Converting IETF RFC-2629 XML into txt


What about to run the tests in ./tests in a %check section?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pHLW2CleyB&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]