Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: zd1211-firmware - Firmware for zd1211 802.11 wireless devices https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221675 notting@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |notting@xxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From notting@xxxxxxxxxx 2007-03-19 15:09 EST ------- Formal review: MUST - Package content is acceptable - OK MUST - Package name follows guidelines - OK MUST - Spec file name is %{name}.spec - OK MUST - Package follows Packaging Guidelines - *** Description: This package is the firmware, not the driver. The description for the -devel subpackage is just wrong. But see below. MUST - BuildRoot is OK - OK MUST - License is OK - OK MUST - License is properly tagged - OK MUST - License is included in package - OK MUST - Spec is in english, and legible - OK MUST - Sources match upstream - *** Snapshot of upstream appears to get retired, so can't check that way. But the code itself matches upstream. MUST - Package builds - OK MUST - Package has proper arch settings - OK MUST - Package has proper BuildRequires - OK MUST - Package handles locales properly - N/A MUST - Package has proper %post scriplets for ldconfig - N/A MUST - Package owns proper directories - OK MUST - Does not own directories it shouldn't - OK MUST - Package is relocatable if necessary - N/A MUST - Package has no duplicate files - OK MUST - Package has proper file permissions - OK MUST - Package has %clean - OK MUST - Package uses macros consistently - OK MUST - Package uses -doc, if needed - N/A MUST - Headers in -devel, if needed - *** Kill the -devel package. -devel is for things that link against an ABI - the firmware does not count for that. MUST - Static libs in -static - N/A MUST - Uses pkgconfig correctly - N/A MUST - Packages .so correctly - N/A MUST - Subpackages have proper Requires: - N/A MUST - Handles libtool correctly - N/A MUST - Uses .desktop, if necessary - N/A SHOULD - Package includes License as file - OK SHOULD - Builds in mock - OK SHOULD - Package functions - Can't test (no hardware) SHOULD - Scriptlets are sane - N/A SHOULD - File dependencies are sane - OK Other notes: The package creates the zd1211b firmware files as well, but the makefile doesn't install them. This should be corrected. Fix that, the description, and kill the -devel package, and it should be good to go. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review