[Bug 957409] Review Request: deepin-utils - Basic modules needed by most Linux Deepin applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=957409

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m



--- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Your srpm link is invalid.


Release:           git%{datetime}%{?dist}

This could cause problems with getting a proper upgrade path. Better:

Release:           1.git%{datetime}%{?dist}

See
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages


BuildRequires:     python-devel
BuildRequires:     pygtk2-devel

python-devel is deprecated, use python2-devel instead:
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
But it is not needed at all, pygtk2-devel depends on it. And you can drop more
of your explicite build requirements which are needed by pygtk2-devel:

pkgconfig(cairo)
pkgconfig(pygobject-2.0)
pkgconfig(glib-2.0)
pkgconfig(gtk+-2.0)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jnNlZQP9kl&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]