https://bugzilla.redhat.com/show_bug.cgi?id=989866 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mario.blaettermann@xxxxxxxx | |m Assignee|nobody@xxxxxxxxxxxxxxxxx |mario.blaettermann@xxxxxxxx | |m Flags| |fedora-review? --- Comment #6 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5848776 $ rpmlint -i -v * discord.armv7hl: I: checking discord.armv7hl: W: spelling-error Summary(en_US) entrainment -> entertainment, entrancement, entrapment The value of this tag appears to be misspelled. Please double-check. discord.armv7hl: W: spelling-error %description -l en_US binaural -> bin aural, bin-aural, inaugural The value of this tag appears to be misspelled. Please double-check. discord.armv7hl: W: spelling-error %description -l en_US entrainment -> entertainment, entrancement, entrapment The value of this tag appears to be misspelled. Please double-check. discord.armv7hl: I: checking-url http://discord.sourceforge.net (timeout 10 seconds) discord.armv7hl: E: non-executable-script /usr/share/discord/convert_sbg_to_discord.py 0644L /usr/bin/python This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. discord.armv7hl: E: incorrect-fsf-address /usr/share/doc/discord/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. discord.i686: I: checking discord.i686: W: spelling-error Summary(en_US) entrainment -> entertainment, entrancement, entrapment The value of this tag appears to be misspelled. Please double-check. discord.i686: W: spelling-error %description -l en_US binaural -> bin aural, bin-aural, inaugural The value of this tag appears to be misspelled. Please double-check. discord.i686: W: spelling-error %description -l en_US entrainment -> entertainment, entrancement, entrapment The value of this tag appears to be misspelled. Please double-check. discord.i686: I: checking-url http://discord.sourceforge.net (timeout 10 seconds) discord.i686: E: non-executable-script /usr/share/discord/convert_sbg_to_discord.py 0644L /usr/bin/python This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. discord.i686: E: incorrect-fsf-address /usr/share/doc/discord/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. discord.src: I: checking discord.src: W: spelling-error Summary(en_US) entrainment -> entertainment, entrancement, entrapment The value of this tag appears to be misspelled. Please double-check. discord.src: W: spelling-error %description -l en_US binaural -> bin aural, bin-aural, inaugural The value of this tag appears to be misspelled. Please double-check. discord.src: W: spelling-error %description -l en_US entrainment -> entertainment, entrancement, entrapment The value of this tag appears to be misspelled. Please double-check. discord.src: I: checking-url http://discord.sourceforge.net (timeout 10 seconds) discord.src:24: W: rpm-buildroot-usage %prep rm -f %{buildroot}%{_datadir}/%{name}/README $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may break short circuit builds. discord.src: I: checking-url http://downloads.sourceforge.net/project/discord/discord-3.2.1.tar.bz2 (timeout 10 seconds) discord.x86_64: I: checking discord.x86_64: W: spelling-error Summary(en_US) entrainment -> entertainment, entrancement, entrapment The value of this tag appears to be misspelled. Please double-check. discord.x86_64: W: spelling-error %description -l en_US binaural -> bin aural, bin-aural, inaugural The value of this tag appears to be misspelled. Please double-check. discord.x86_64: W: spelling-error %description -l en_US entrainment -> entertainment, entrancement, entrapment The value of this tag appears to be misspelled. Please double-check. discord.x86_64: I: checking-url http://discord.sourceforge.net (timeout 10 seconds) discord.x86_64: E: non-executable-script /usr/share/discord/convert_sbg_to_discord.py 0644L /usr/bin/python This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. discord.x86_64: E: incorrect-fsf-address /usr/share/doc/discord/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. discord-debuginfo.armv7hl: I: checking discord-debuginfo.armv7hl: I: checking-url http://discord.sourceforge.net (timeout 10 seconds) discord-debuginfo.armv7hl: E: debuginfo-without-sources This debuginfo package appears to contain debug symbols but no source files. This is often a sign of binaries being unexpectedly stripped too early during the build, or being compiled without compiler debug flags (which again often is a sign of distro's default compiler flags ignored which might have security consequences), or other compiler flags which result in rpmbuild's debuginfo extraction not working as expected. Verify that the binaries are not unexpectedly stripped and that the intended compiler flags are used. discord-debuginfo.i686: I: checking discord-debuginfo.i686: I: checking-url http://discord.sourceforge.net (timeout 10 seconds) discord-debuginfo.i686: E: debuginfo-without-sources This debuginfo package appears to contain debug symbols but no source files. This is often a sign of binaries being unexpectedly stripped too early during the build, or being compiled without compiler debug flags (which again often is a sign of distro's default compiler flags ignored which might have security consequences), or other compiler flags which result in rpmbuild's debuginfo extraction not working as expected. Verify that the binaries are not unexpectedly stripped and that the intended compiler flags are used. discord-debuginfo.x86_64: I: checking discord-debuginfo.x86_64: I: checking-url http://discord.sourceforge.net (timeout 10 seconds) discord-debuginfo.x86_64: E: debuginfo-without-sources This debuginfo package appears to contain debug symbols but no source files. This is often a sign of binaries being unexpectedly stripped too early during the build, or being compiled without compiler debug flags (which again often is a sign of distro's default compiler flags ignored which might have security consequences), or other compiler flags which result in rpmbuild's debuginfo extraction not working as expected. Verify that the binaries are not unexpectedly stripped and that the intended compiler flags are used. discord.spec:24: W: rpm-buildroot-usage %prep rm -f %{buildroot}%{_datadir}/%{name}/README $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may break short circuit builds. discord.spec: I: checking-url http://downloads.sourceforge.net/project/discord/discord-3.2.1.tar.bz2 (timeout 10 seconds) 7 packages and 1 specfiles checked; 9 errors, 14 warnings. Some old FSF addresses, which are worth to be reported upstream. Please remove the shebang from /usr/share/discord/convert_sbg_to_discord.py. The debuginfo package is empty. In most cases this is due to wrong upstream compiler flags. Discord is written in C, the following change should help: make CFLAGS='%{optflags}' %{?_smp_mflags} The rpm-buidroot-usage warning should be taken as serious. As far as I can see, discord installs the README file in /usr/share/discord, but you want to have it in %doc. Your command in %prep doesn't do the trick: $ rpm -qpl discord-3.2.1-2.fc20.i686.rpm /usr/bin/discord /usr/share/discord /usr/share/discord/README ... /usr/share/doc/discord/README /usr/share/man/man1/discord.1.gz You have to remove the README file in %build after running configure and make or even after make install. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KoCJDYDb8k&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review