https://bugzilla.redhat.com/show_bug.cgi?id=998238 Baptiste Mille-Mathias <baptiste.millemathias@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | --- Comment #5 from Baptiste Mille-Mathias <baptiste.millemathias@xxxxxxxxx> --- (In reply to Haïkel Guémar from comment #2) > If you're still looking for a sponsor, i'm willing to start the process with > you. Yes > Concerning your review: > 1. you don't need to clean up the buildroot (unless, you want to support EL5 > but if that's the case, there are many missing bits to do so) I guess you refer to %install rm -rf $RPM_BUILD_ROOT tbh, I used the template created by rpmdev-newspec and add the content needed to build around that. I'll remove that part. > 2. requires are likely to be useless, since RPM may compute them for you Okay, I'll remove that too. > > For the sponsorship, i'll requires you do two (non trivial !) informal > package reviews of your choice so i can assess your knowledge of RPM > packaging. Ok, I'm currently reading the guidelines and finding accurate documentation. I can get back to you next week regarding the reviews process I have to do. > I'll also assess your involvement, though it should be OK in your > case (you're already a FOSS veteran and have good relationship with upstream > which even took the time to answer in your review :) ) Thanks!! > Make sure to read our guidelines, and feel free to ask me about them and our > packaging process. Sure. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GrNaXC55sn&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review