https://bugzilla.redhat.com/show_bug.cgi?id=989015 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #9 from Kevin Fenzi <kevin@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 8075530b2ad0a2fbd4bffa80a96eb2ea release-2.2.0.tar.gz 8075530b2ad0a2fbd4bffa80a96eb2ea release-2.2.0.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: makeself.noarch: W: spelling-error Summary(en_US) extractable -> ex tractable, ex-tractable, extract able makeself.noarch: W: spelling-error %description -l en_US extractable -> ex tractable, ex-tractable, extract able makeself.noarch: W: spelling-error %description -l en_US gz -> g, z, gs makeself.noarch: W: spelling-error %description -l en_US uncompress -> uncompressed, compression, compressor makeself.src: W: spelling-error Summary(en_US) extractable -> ex tractable, ex-tractable, extract able makeself.src: W: spelling-error %description -l en_US extractable -> ex tractable, ex-tractable, extract able makeself.src: W: spelling-error %description -l en_US gz -> g, z, gs makeself.src: W: spelling-error %description -l en_US uncompress -> uncompressed, compression, compressor 2 packages and 0 specfiles checked; 0 errors, 8 warnings. all can be ignored. This is a pretty simple package. ;) I don't see any further issues, so this package is APPROVED and I will sponsor you. You can continue the process from: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner Please let me know if you have any questions or get stuck anywhere. ;) Welcome! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CdacmwPqAC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review