https://bugzilla.redhat.com/show_bug.cgi?id=871205 --- Comment #3 from Mario Ceresa <mrceresa@xxxxxxxxx> --- Hi Rich, I have some minor issues here: * Please set CMAKE_BUILD_TYPE to either Release or RelWithDebInfo. Upstream might change their default without notice. I usually put RelWithDebInfo: http://stackoverflow.com/questions/1239845/build-mode-relwithdebinfo but I have no strong opinion here. * Did you notice upstream changed from bitbucket to github? https://github.com/ros/urdfdom You should update accordingly the spec-file and generate-tarball or just use the links provided at: https://github.com/ros/urdfdom/releases * Latest release is 0.2.8 :) As per the libraries with missing soname, I fear it is a real error. There are at least two alternatives here: (1) You could contact upstream and ask them to add soname information to cmake files (probably the best way because they will manage ABI/API breakage) (2) If upstream is not responsive, you could manually add soname info like that: --- Top CMakeLists.txt ----- +set (URDF_API_VERSION ${URDF_MAJOR_VERSION}.${URDF_MINOR_VERSION}) + +SET(URDF_LIBRARY_PROPERTIES + VERSION "${URDF_VERSION}" + SOVERSION "${URDF_API_VERSION}" +) ------------------------------- --- urdf_parser/CMakeLists.txt ----- +SET_TARGET_PROPERTIES(urdfdom_world PROPERTIES ${URDF_LIBRARY_PROPERTIES}) +SET_TARGET_PROPERTIES(urdfdom_model PROPERTIES ${URDF_LIBRARY_PROPERTIES}) +SET_TARGET_PROPERTIES(urdfdom_sensor PROPERTIES ${URDF_LIBRARY_PROPERTIES}) +SET_TARGET_PROPERTIES(urdfdom_model_state PROPERTIES ${URDF_LIBRARY_PROPERTIES}) ------------------------------------- Please comment on my previous issues and I'll continue the review. Best, Mario -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SMP1OaA8Ej&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review