[Bug 854723] Review Request: bat - Binary Analysis Tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=854723



--- Comment #10 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> ---
Some more comments:

- The BR for python should be 'BR: python2-devel'
- The license tag is wrong, ASL 2.0 is the right one
- There are two different SPEC files. The one in the SRPM is not the same as
the one you provide. At least different 'Release' tag.
- Check the rpmlint output:

$ rpmlint bat-14.0-1.1.src.rpm 
bat.src: W: invalid-license Apache 2.0
bat.src: W: invalid-url DistURL
obs://build.opensuse.org/home:bluebat/Fedora_19/0624bc1a1dddc024b08c4f9309b83a50-bat
bat.src: E: unknown-key GPG#17a4ea30
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

$ rpmlint bat-14.0-1.1.noarch.rpm 
bat.noarch: E: explicit-lib-dependency libmp4v2
bat.noarch: E: explicit-lib-dependency libxml2
bat.noarch: E: explicit-lib-dependency python-matplotlib
bat.noarch: W: incoherent-version-in-changelog 14.0-1 ['14.0-1.1', '14.0-1.1']
bat.noarch: W: invalid-license Apache 2.0
bat.noarch: W: non-conffile-in-etc /etc/bat/configs/1.7.4-config
bat.noarch: W: non-conffile-in-etc /etc/bat/configs/1.00-config
bat.noarch: W: non-conffile-in-etc /etc/bat/configs/1.2.1-config
[snip]
bat.noarch: W: no-manual-page-for-binary bruteforce.py
1 packages and 0 specfiles checked; 30 errors, 105 warnings.

- Are you still looking for a sponsor?
  https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nYnVD31EXg&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]