https://bugzilla.redhat.com/show_bug.cgi?id=990272 --- Comment #2 from Dan Williams <dcbw@xxxxxxxxxx> --- (In reply to Michael Schwendt from comment #1) > Only skimmed over the spec: > > > > Name: libmbim > > Group: Development/Libraries > > The group for run-time libs has been "System Environment/Libraries" for many > years. Alternatively, drop the Group tag. Dropped. > > > Requires: glib2 >= %{glib2_version} > > Add %{?_isa} here and also a comment giving the rationale why this minimum > version is strictly needed. > > https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires As F18+ and later meet the minimum requirement, I've removed the explicit version requirement and added {?_isa}. > > > %package devel > > Requires: glib2-devel > > Add %{?_isa} here, too. Done. > > Requires: pkgconfig > > There's an automatic dep on /usr/bin/pkgconfig already. Removed. > > %post devel -p /sbin/ldconfig > > %postun devel -p /sbin/ldconfig > > Not needed, and we don't run ldconfig for -devel packages. Removed. > > %files devel > > %dir %{_includedir}/libmbim-glib > > %{_includedir}/libmbim-glib/*.h > > A single line could replace those two above, too: > > %{_includedir}/libmbim-glib/ Done. > > %dir %{_datadir}/gtk-doc/html/libmbim-glib > > %{_datadir}/gtk-doc/html/libmbim-glib/* > > If you don't let the package require "gtk-doc", own all directories: > > %dir %{_datadir}/gtk-doc > %dir %{_datadir}/gtk-doc/html Done. > https://fedoraproject.org/wiki/Packaging: > Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your > _package_to_function > > Of course, you could include the entire tree with a single line: > > %{_datadir}/gtk-doc/ gli2 also provides some gtk-doc, and while that's currently stored in glib2-doc it has switched around in the past between -devel (which is a BuildRequire) and -docs so I'm more comfortable explicitly owning the relevant dirs than all of them. Specfile and SRPM updated in same location as comment 1. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nyWzbgg9HD&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review