https://bugzilla.redhat.com/show_bug.cgi?id=990272 --- Comment #1 from Michael Schwendt <bugs.michael@xxxxxxx> --- Only skimmed over the spec: > Name: libmbim > Group: Development/Libraries The group for run-time libs has been "System Environment/Libraries" for many years. Alternatively, drop the Group tag. > Requires: glib2 >= %{glib2_version} Add %{?_isa} here and also a comment giving the rationale why this minimum version is strictly needed. https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires > %package devel > Requires: glib2-devel Add %{?_isa} here, too. > Requires: pkgconfig There's an automatic dep on /usr/bin/pkgconfig already. > %post devel -p /sbin/ldconfig > %postun devel -p /sbin/ldconfig Not needed, and we don't run ldconfig for -devel packages. > %files devel > %dir %{_includedir}/libmbim-glib > %{_includedir}/libmbim-glib/*.h A single line could replace those two above, too: %{_includedir}/libmbim-glib/ > %dir %{_datadir}/gtk-doc/html/libmbim-glib > %{_datadir}/gtk-doc/html/libmbim-glib/* If you don't let the package require "gtk-doc", own all directories: %dir %{_datadir}/gtk-doc %dir %{_datadir}/gtk-doc/html https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function Of course, you could include the entire tree with a single line: %{_datadir}/gtk-doc/ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Oec97CgSN1&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review