[Bug 994434] Review Request: kompare - Diff tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=994434



--- Comment #4 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> ---
> Obsoletes:      kdesdk-kompare < 4.10.80
>
> doesn't include all versions prior to the current one. Either use
>
> Obsoletes:      kdesdk-kompare <= 4.10.80
>
> or refer to the current package version:
>
> Obsoletes:      kdesdk-kompare < %{version}
>
> Well, in this certain case there won't be a kompare-4.10.97 due to the new
> release policy, but we would be on the safer side in any case.

I think it is actually the best practice to not Obsolete more than necessary,
and also, Obsoletes with <= is usually a bad idea. (It may work with Version
only (as here), but if you try using <= with a Version-Release, you'll have
trouble with the disttags.) And < %{version} in Obsoletes is also not that
nice, it will unnecessarily Obsolete versions that were never released in the
first place.

I'd keep < 4.10.80 for the Obsoletes version here.


> It's not useful to repeat the summary in the descriptions.

Well, that's what we use here in the KDE SIG when we cannot think of a better
description. ;-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uIJ6iCgqqY&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]