https://bugzilla.redhat.com/show_bug.cgi?id=994434 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@xxxxxxxx | |m --- Comment #3 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Just a few initial comments: Don't use hardcoded paths in the file lists. /usr/include/kde4/kompare/kompareinterface.h has to be %{_kde4_includedir}/kompare/kompareinterface.h See https://fedoraproject.org/wiki/SIGs/KDE/Packaging/BestPractices?rd=SIGs/KDE/Packaging/Guidelines#Macros Obsoletes: kdesdk-kompare < 4.10.80 doesn't include all versions prior to the current one. Either use Obsoletes: kdesdk-kompare <= 4.10.80 or refer to the current package version: Obsoletes: kdesdk-kompare < %{version} Well, in this certain case there won't be a kompare-4.10.97 due to the new release policy, but we would be on the safer side in any case. It's not useful to repeat the summary in the descriptions. My suggestions: %description libs This package contains shared libraries for %{name}. %description devel The %{name}-devel package contains libraries and header files for developing applications that use %{name}. Moreover, rpmlint gives me the following error message for your spec file: kompare.spec:26: W: unversioned-explicit-provides mergetool The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. Would be be useful here to add the version number, as you already did in the Obsoletes: and Conflicts: tags? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eYrfJ8BvPr&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review